Re: ALTER COLUMN ... SET EXPRESSION to alter stored generated column's expression

amul sul <sulamul@gmail.com>

From: Amul Sul <sulamul@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: Robert Haas <robertmhaas@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, Vaibhav Dalvi <vaibhav.dalvi@enterprisedb.com>, pgsql-hackers@postgresql.org

Date: 2023-11-09T12:00:49Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

ALTER TABLE command to change generation expression
- 5d06e99a3cfc 17.0 landed
Refactor: separate function to find all objects depending on a column
- d4e66a39eb96 17.0 landed
Turn AT_PASS_* macros into an enum
- cea89c93a102 17.0 landed

Attachments

v3-0001-Prerequisite-changes-rename-functions-enum.patch (application/octet-stream) patch v3-0001
v3-0002-Allow-to-change-generated-column-expression.patch (application/octet-stream) patch v3-0002

On Tue, Nov 7, 2023 at 8:21 PM Peter Eisentraut <peter@eisentraut.org>
wrote:

> On 25.10.23 08:12, Amul Sul wrote:
> > Here is the rebase version for the latest master head(673a17e3120).
> >
> > I haven't done any other changes related to the ON UPDATE trigger since
> that
> > seems non-trivial; need a bit of work to add trigger support in
> > ATRewriteTable().
> > Also, I am not sure yet, if we were doing these changes, and the correct
> > direction
> > for that.
>
> I did some detailed testing on Db2, Oracle, and MariaDB (the three
> existing implementations of this feature that I'm tracking), and none of
> them fire any row or statement triggers when the respective statement to
> alter the generation expression is run.  So I'm withdrawing my comment
> that this should fire triggers.  (I suppose event triggers are available
> if anyone really needs the functionality.)
>

Thank you for the confirmation.

Here is the updated version patch. Did minor changes to documents and tests.

Regards,
Amul