Refactoring: Use soft error reporting for *_opt_error functions

amul sul <sulamul@gmail.com>

From: Amul Sul <sulamul@gmail.com>

To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-09-01T09:35:16Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix two comments in numeric.c
- 0c7f10302820 19 (unreleased) landed
Switch some numeric-related functions to use soft error reporting
- 4246a977bad6 19 (unreleased) landed
Change pg_lsn_in_internal() to use soft error reporting
- ae453120085f 19 (unreleased) landed

Attachments

0001-Change-_opt_error-to-soft-error-reporting.patch (application/x-patch) patch 0001

Hi,

While reviewing version v6 of the CAST(... ON DEFAULT) patch [1], I
noticed that it attempts to change the type conversion function to use
soft error reporting. However, some of the underlying functions of the
type conversion, such as *_opt_error, still rely on a boolean argument
passed by the caller. This results in an error flag being set rather
than a proper error being thrown.

I believe we should update all *_opt_error functions to use the new
soft error reporting infrastructure instead of boolean flags -- did
the same in the attached patch. I am not sure if this patch should be
part of that thread[1]. It's a significant improvement in itself, as
it would make the code more compact and consistent.

1]http://postgr.es/m/CACJufxE053=bO3pDUpGba6Yz3VGpU_XCbg4HO6Rew5EJ7k7VnQ@mail.gmail.com

--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com