Re: NOT ENFORCED constraint feature

amul sul <sulamul@gmail.com>

From: Amul Sul <sulamul@gmail.com>

To: Álvaro Herrera <alvherre@alvh.no-ip.org>

Cc: Peter Eisentraut <peter@eisentraut.org>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, jian he <jian.universality@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Joel Jacobson <joel@compiler.org>, Suraj Kharage <suraj.kharage@enterprisedb.com>

Date: 2025-02-27T06:56:33Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add support for NOT ENFORCED in foreign key constraints
- eec0040c4bcd 18.0 landed
Expand test a bit
- 5d5f415816a6 18.0 landed
refactor: Pass relation OID instead of Relation to createForeignKeyCheckTriggers()
- ef7a5af77d44 18.0 landed
refactor: Split ATExecAlterConstraintInternal()
- 639238b978fe 18.0 landed
refactor: Move some code that updates pg_constraint to a separate function
- a3280e2a494f 18.0 landed
Move RemoveInheritedConstraint() call slightly earlier
- dabccf45139a 18.0 landed
refactor: Split tryAttachPartitionForeignKey()
- 1d26c2d2c4b8 18.0 landed
refactor: re-add ATExecAlterChildConstr()
- 64224a834ce4 18.0 landed
Add ATAlterConstraint struct for ALTER .. CONSTRAINT
- 80d7f990496b 18.0 landed
refactor: split ATExecAlterConstrRecurse()
- 7a947ed25b54 18.0 landed
Add support for NOT ENFORCED in CHECK constraints
- ca87c415e2fc 18.0 landed

Attachments

v15-0001-refactor-re-add-ATExecAlterChildConstr.patch (application/octet-stream) patch v15-0001
v15-0002-refactor-Split-tryAttachPartitionForeignKey.patch (application/octet-stream) patch v15-0002
v15-0003-Move-the-RemoveInheritedConstraint-function-call.patch (application/octet-stream) patch v15-0003
v15-0004-refactor-Pass-Relid-instead-of-Relation-to-creat.patch (application/octet-stream) patch v15-0004
v15-0005-refactor-Change-ATExecAlterConstrRecurse-argumen.patch (application/octet-stream) patch v15-0005
v15-0006-Remove-hastriggers-flag-check-before-fetching-FK.patch (application/octet-stream) patch v15-0006
v15-0007-Ease-the-restriction-that-a-NOT-ENFORCED-constra.patch (application/octet-stream) patch v15-0007
v15-0008-Add-support-for-NOT-ENFORCED-in-foreign-key-cons.patch (application/octet-stream) patch v15-0008
v15-0009-Merge-the-parent-and-child-constraints-with-diff.patch (application/octet-stream) patch v15-0009

On Tue, Feb 18, 2025 at 2:13 PM Álvaro Herrera <alvherre@alvh.no-ip.org> wrote:
>
> On 2025-Feb-18, Amul Sul wrote:
>
> > The patch looks quite reasonable, but I’m concerned that renaming
> > ATExecAlterConstrRecurse() and ATExecAlterChildConstr() exclusively
> > for deferrability might require the enforceability patch to duplicate
> > these functions, even though some operations (e.g., pg_constraint
> > updates and recursion on child constraints) could have been reused.
>
> True.  I'll give another look to your 0008 and Suraj's patch for
> inheritability change, to avoid repetitive boilerplate as much as
> possible.
>

Thanks, Álvaro, for committing the 0001 patch -- it really helps.

Attached is the rebased patch set against the latest master head,
which also includes a *new* refactoring patch (0001). In this patch,
I’ve re-added ATExecAlterChildConstr(), which is required for the main
feature patch (0008) to handle recursion from different places while
altering enforceability.

Regards,
Amul