Re: Refactoring: Use soft error reporting for *_opt_error functions

amul sul <sulamul@gmail.com>

From: Amul Sul <sulamul@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, jian he <jian.universality@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-09-05T05:12:26Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix two comments in numeric.c
- 0c7f10302820 19 (unreleased) landed
Switch some numeric-related functions to use soft error reporting
- 4246a977bad6 19 (unreleased) landed
Change pg_lsn_in_internal() to use soft error reporting
- ae453120085f 19 (unreleased) landed

On Fri, Sep 5, 2025 at 10:28 AM Michael Paquier <michael@paquier.xyz> wrote:
>
> On Fri, Sep 05, 2025 at 08:10:00AM +0900, Michael Paquier wrote:
> > Sure.  I'll handle it.  Thanks.
>
> Applied after a few tweaks, including changes to the comments, the
> suggestion of "division_by_zero" for the goto labels, and splitting
> the patch into two parts for pg_lsn and numeric.

Thanks for improving and committing the patch. I see now that two
separate commits were definitely needed, and I should have submitted
them that way. Thank you again for splitting it into two parts.

Regards,
Amul