Re: [Patch] ALTER SYSTEM READ ONLY

Amul Sul <sulamul@gmail.com>

From: Amul Sul <sulamul@gmail.com>

To: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>

Cc: Prabhat Sahu <prabhat.sahu@enterprisedb.com>, Ibrar Ahmed <ibrar.ahmad@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Andres Freund <andres@anarazel.de>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2021-04-05T11:57:17Z

Lists: pgsql-hackers

Attachments

v24-0001-Implement-wal-prohibit-state-using-global-barrie.patch (application/x-patch) patch v24-0001
v24-0003-Documentation.patch (application/x-patch) patch v24-0003
v24-0002-Error-or-Assert-before-START_CRIT_SECTION-for-WA.patch (application/x-patch) patch v24-0002

On Mon, Apr 5, 2021 at 4:45 PM Bharath Rupireddy
<bharath.rupireddyforpostgres@gmail.com> wrote:
>

Thanks Bharath for your review.

> On Mon, Apr 5, 2021 at 11:02 AM Amul Sul <sulamul@gmail.com> wrote:
> >
> > Attached is the rebase version for the latest master head(commit # 9f6f1f9b8e6).
>
> Some minor comments on 0001:
> Isn't it "might not be running"?
> +                 errdetail("Checkpointer might not running."),
>

Ok, fixed in the attached version.

> Isn't it  "Try again after sometime"?
> +                         errhint("Try after sometime again.")));
>

Ok, done.

> Can we have ereport(DEBUG1 just to be consistent(although it doesn't
> make any difference from elog(DEBUG1) with the new log messages
> introduced in the patch?
> +    elog(DEBUG1, "waiting for backends to adopt requested WAL
> prohibit state change");
>

I think it's fine; many existing places have used elog(DEBUG1, ....) too.

Regards,
Amul

Commits

Initialize variable to placate compiler.
- a030a0c5ccb1 15.0 landed
StartupXLOG: Don't repeatedly disable/enable local xlog insertion.
- 18e0913a4203 15.0 landed
StartupXLOG: Call CleanupAfterArchiveRecovery after XLogReportParameters.
- a75dbf7f9ee6 15.0 landed
Postpone some end-of-recovery operations related to allowing WAL.
- 811051c2e7af 15.0 landed
Refactor some end-of-recovery code out of StartupXLOG().
- 6df1543abfed 15.0 landed
Re-enable contrib/bloom's TAP tests.
- 7d1aa6bf1c27 15.0 cited
Remove unnecessary call to ReadCheckpointRecord().
- 1d919de5eb3f 15.0 cited
Allow for error or refusal while absorbing a ProcSignalBarrier.
- a3ed4d1efe9f 14.0 landed
Add comment to explain an unused function parameter
- 101f903e51f5 14.0 cited
Extend the ProcSignal mechanism to support barriers.
- 16a4e4aecd47 13.0 cited
At promotion, don't leave behind a partial segment on the old timeline.
- 7cbee7c0a1db 9.5.0 cited