Re: alter check constraint enforceability

amul sul <sulamul@gmail.com>

From: Amul Sul <sulamul@gmail.com>

To: jian he <jian.universality@gmail.com>

Cc: Robert Treat <rob@xzilla.net>, Kirill Reshke <reshkekirill@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2025-12-15T11:49:00Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add support for altering CHECK constraint enforceability
- 342051d73b38 19 (unreleased) landed
rename alter constraint enforceability related functions
- a9747153e14d 19 (unreleased) landed

On Fri, Dec 12, 2025 at 1:25 PM jian he <jian.universality@gmail.com> wrote:
>
> On Mon, Dec 8, 2025 at 5:58 PM Amul Sul <sulamul@gmail.com> wrote:
>>  [....]
>
> v5-0001:
> AlterConstrEnforceabilityRecurse renamed to AlterFKConstrEnforceabilityRecurse n
> ATExecAlterConstrEnforceability renamed to ATExecAlterFKConstrEnforceability.
> comments slightly adjusted, no other changes.
>

Looks good to me, thanks !

> v5-0002: alter check constraint enforceability
>

The patch also looks good, but I have a minor comment for the test --
you created the check_constraint_status view, which is not dropped, it
should be dropped at the end. Also, instead of a view, I think you
could use the \set psql-meta-command; for example, see the
init_range_parted or show_data tests in update.sql

Also, run pgindent on both patches.

Regards,
Amul