Horton
Menu

Thread

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. plsample: Use TextDatumGetCString() for text-to-CString conversion

  1. Cleanup: Use modern macro for text-to-CString conversion in plsample.c

    amul sul <sulamul@gmail.com> — 2026-04-17T12:54:58Z

    Hi,

I noticed that plsample.c uses an outdated method to convert text data
to a C string. This old method calls the textout function manually,
which adds unnecessary overhead.

The attached patch replaces this with the TextDatumGetCString() macro.
This macro is more efficient and automatically handles "detoasting"
(decompressing/fetching) the data.

Since plsample serves as a template for developers writing new
extensions, it should follow current best practices. This patch
updates the code in both the function and trigger handlers.

--
Regards,
Amul Sul
EDB: http://www.enterprisedb.com

  2. Re: Cleanup: Use modern macro for text-to-CString conversion in plsample.c

    Fujii Masao <masao.fujii@gmail.com> — 2026-04-20T12:20:22Z

    On Fri, Apr 17, 2026 at 9:55 PM Amul Sul <sulamul@gmail.com> wrote:
>
> Hi,
>
> I noticed that plsample.c uses an outdated method to convert text data
> to a C string. This old method calls the textout function manually,
> which adds unnecessary overhead.
>
> The attached patch replaces this with the TextDatumGetCString() macro.
> This macro is more efficient and automatically handles "detoasting"
> (decompressing/fetching) the data.
>
> Since plsample serves as a template for developers writing new
> extensions, it should follow current best practices. This patch
> updates the code in both the function and trigger handlers.

LGTM.

Regards,



-- 
Fujii Masao

  3. Re: Cleanup: Use modern macro for text-to-CString conversion in plsample.c

    Fujii Masao <masao.fujii@gmail.com> — 2026-04-20T23:41:38Z

    On Mon, Apr 20, 2026 at 9:20 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> LGTM.

I've pushed the patch. Thanks!

Regards,

-- 
Fujii Masao

  4. Re: Cleanup: Use modern macro for text-to-CString conversion in plsample.c

    amul sul <sulamul@gmail.com> — 2026-04-21T03:57:09Z

    On Tue, Apr 21, 2026 at 5:11 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Mon, Apr 20, 2026 at 9:20 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> > LGTM.
>
> I've pushed the patch. Thanks!
>

Thank you, Fujii-san.

Regards,
Amul