Re: NOT ENFORCED constraint feature

amul sul <sulamul@gmail.com>

From: Amul Sul <sulamul@gmail.com>

To: jian he <jian.universality@gmail.com>

Cc: Peter Eisentraut <peter@eisentraut.org>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers <pgsql-hackers@postgresql.org>, Joel Jacobson <joel@compiler.org>

Date: 2025-02-04T10:34:57Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add support for NOT ENFORCED in foreign key constraints
- eec0040c4bcd 18.0 landed
Expand test a bit
- 5d5f415816a6 18.0 landed
refactor: Pass relation OID instead of Relation to createForeignKeyCheckTriggers()
- ef7a5af77d44 18.0 landed
refactor: Split ATExecAlterConstraintInternal()
- 639238b978fe 18.0 landed
refactor: Move some code that updates pg_constraint to a separate function
- a3280e2a494f 18.0 landed
Move RemoveInheritedConstraint() call slightly earlier
- dabccf45139a 18.0 landed
refactor: Split tryAttachPartitionForeignKey()
- 1d26c2d2c4b8 18.0 landed
refactor: re-add ATExecAlterChildConstr()
- 64224a834ce4 18.0 landed
Add ATAlterConstraint struct for ALTER .. CONSTRAINT
- 80d7f990496b 18.0 landed
refactor: split ATExecAlterConstrRecurse()
- 7a947ed25b54 18.0 landed
Add support for NOT ENFORCED in CHECK constraints
- ca87c415e2fc 18.0 landed

Attachments

v12-0001-Add-AlterConstraintStmt-struct-for-ALTER-.-CONST.patch (application/octet-stream) patch v12-0001
v12-0002-refactor-Split-tryAttachPartitionForeignKey.patch (application/octet-stream) patch v12-0002
v12-0003-refactor-Pass-Relid-instead-of-Relation-to-creat.patch (application/octet-stream) patch v12-0003
v12-0004-refactor-Change-ATExecAlterConstrRecurse-argumen.patch (application/octet-stream) patch v12-0004
v12-0005-Remove-hastriggers-flag-check-before-fetching-FK.patch (application/octet-stream) patch v12-0005
v12-0006-Add-support-for-NOT-ENFORCED-in-foreign-key-cons.patch (application/octet-stream) patch v12-0006
v12-0007-Merge-the-parent-and-child-constraints-with-diff.patch (application/octet-stream) patch v12-0007

On Mon, Feb 3, 2025 at 9:39 AM Amul Sul <sulamul@gmail.com> wrote:
>
> On Sat, Feb 1, 2025 at 8:31 PM jian he <jian.universality@gmail.com> wrote:
> >
> > [...]
> > So the code should only call AlterConstrTriggerDeferrability,
> > not call ATExecAlterConstrEnforceability?
>
> Right. Thank you for the report. We need to know whether the
> enforceability and/or deferability has actually been set or not before
> catalog update.
>

Fixed in the attached version. A new patch, 0001, introduces a new
struct, AlterConstraintStmt, which carries the necessary information
for enforceability and deferrability modifications of a constraint, as
implemented in patch 0006.

Regards,
Amul