Horton

Re: Refactoring: Use soft error reporting for *_opt_error functions

amul sul <sulamul@gmail.com>

View thread
From: Amul Sul <sulamul@gmail.com>
To: Dean Rasheed <dean.a.rasheed@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-09-03T11:51:55Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Fix two comments in numeric.c

  2. Switch some numeric-related functions to use soft error reporting

  3. Change pg_lsn_in_internal() to use soft error reporting

Attachments

On Wed, Sep 3, 2025 at 1:04 PM Dean Rasheed <dean.a.rasheed@gmail.com> wrote:
>
> On Wed, 3 Sept 2025 at 07:47, Michael Paquier <michael@paquier.xyz> wrote:
> >
> > The same error message is repeated twice.  How about using some gotos
> > and one single ereport instead of two?  The same can be said for
> > numeric_div_safe() and numeric_mod_safe(), for the division-by-0
> > messages.
>
> In numeric_div_safe() and numeric_mod_safe():
>
> -     * If "have_error" is provided, check for division by zero here
> +     * If "escontext" is provided, raise division by zero soft error here
>       */
> -    if (have_error && (arg2.ndigits == 0 || arg2.digits[0] == 0))
> -    {
> -        *have_error = true;
> -        return NULL;
> -    }
> +    if (escontext && (arg2.ndigits == 0 || arg2.digits[0] == 0))
> +        ereturn(escontext, NULL,
> +                errcode(ERRCODE_DIVISION_BY_ZERO),
> +                errmsg("division by zero"));
>
> This might as well now be made to check for division-by-zero even if
> escontext is NULL.

Agreed -- did the same in the attached version including the error
deduplication that Michael suggested.

Regards,
Amul