Horton

Re: path toward faster partition pruning

Amul Sul <sulamul@gmail.com>

View thread View on postgr.es
From: amul sul <sulamul@gmail.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>, Jesper Pedersen <jesper.pedersen@redhat.com>, David Rowley <david.rowley@2ndquadrant.com>, Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2017-09-27T06:20:06Z
Lists: pgsql-hackers 
On Wed, Sep 27, 2017 at 6:09 AM, Amit Langote <Langote_Amit_f8@lab.ntt.co.jp
> wrote:

> On 2017/09/27 1:51, Robert Haas wrote:
> > On Tue, Sep 26, 2017 at 10:57 AM, Jesper Pedersen
> > <jesper.pedersen@redhat.com> wrote:
> >> One could advocate (*cough*) that the hash partition patch [1] should be
> >> merged first in order to find other instances of where other CommitFest
> >> entries doesn't account for hash partitions at the moment in their
> method
> >> signatures; Beena noted something similar in [2]. I know that you said
> >> otherwise [3], but this is CommitFest 1, so there is time for a revert
> >> later, and hash partitions are already useful in internal testing.
> >
> > Well, that's a fair point.  I was assuming that committing things in
> > that order would cause me to win the "least popular committer" award
> > at least for that day, but maybe not.  It's certainly not ideal to
> > have to juggle that patch along and keep rebasing it over other
> > changes when it's basically done, and just waiting on other
> > improvements to land.  Anybody else wish to express an opinion?
>
> FWIW, I tend to agree that it would be nice to get the hash partitioning
> patch in, even with old constraint exclusion based partition-pruning not
> working for hash partitions.  That way, it might be more clear what we
> need to do in the partition-pruning patches to account for hash partitions.
>
​
+1

regards,
Amul​

Commits

  1. Fix assorted partition pruning bugs

  2. Make gen_partprune_steps static

  3. Remove useless 'default' clause

  4. Reorganize partitioning code

  5. Use custom hash opclass for hash partition pruning

  6. Blindly attempt to fix sepgsql tests broken due to 9fdb675fc5.

  7. Attempt to fix endianess issues in new hash partition test.

  8. Faster partition pruning

  9. For partitionwise join, match on partcollation, not parttypcoll.

  10. Revise API for partition bound search functions.

  11. Revise API for partition_rbound_cmp/partition_rbound_datum_cmp.

  12. Fix possible crash in partition-wise join.

  13. Refactor code for partition bound searching

  14. New C function: bms_add_range

  15. Add extensive tests for partition pruning.

  16. Add null test to partition constraint for default range partitions.

  17. Remove BufFile's isTemp flag.

  18. Make OWNER TO subcommand mention consistent

  19. Fix index matching for operators with mixed collatable/noncollatable inputs.