Horton

Re: Cleanup isolation specs from unused steps

Melanie Plageman <melanieplageman@gmail.com>

View thread View on postgr.es
From: Melanie Plageman <melanieplageman@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-08-19T17:23:19Z
Lists: pgsql-hackers 
On Mon, Aug 19, 2019 at 1:08 AM Michael Paquier <michael@paquier.xyz> wrote:

> Hi all,
>
> I have been looking at the isolation tests, and we have in some specs
> steps which are defined but not used in any permutations.  In order to
> detect them, I have been using the attached trick to track which
> permutations are used.  This allows to find immediately any
> over-engineered spec by generating diffs about steps defined by not
> used in any permutations.  On HEAD, we have six specs entering in this
> category.
>
> Would that be useful?
>

I think it is useful.

could you do the check that all steps have been used in dry_run mode
instead of when running the tests for real?

-- 
Melanie Plageman

Commits

  1. Detect unused steps in isolation specs and do some cleanup

  2. Remove dry-run mode from isolationtester