Re: heapgettup refactoring

Melanie Plageman <melanieplageman@gmail.com>

View thread View on postgr.es

From: Melanie Plageman <melanieplageman@gmail.com>

To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>

Cc: Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2022-11-30T22:34:50Z

Lists: pgsql-hackers

Attachments

v3-0005-Add-heapgettup-helpers.patch (text/x-patch) patch v3-0005
v3-0002-Push-lpp-variable-closer-to-usage-in-heapgetpage.patch (text/x-patch) patch v3-0002
v3-0003-Add-heapgettup_initial_page-helper.patch (text/x-patch) patch v3-0003
v3-0001-Add-no-movement-scan-helper.patch (text/x-patch) patch v3-0001
v3-0004-Streamline-heapgettup-for-refactor.patch (text/x-patch) patch v3-0004
v3-0007-Refactor-heapgettup-and-heapgettup_pagemode.patch (text/x-patch) patch v3-0007
v3-0006-Add-heapgettup_advance_page.patch (text/x-patch) patch v3-0006

On Wed, Nov 16, 2022 at 10:49 AM Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
>
> On 04.11.22 16:51, Melanie Plageman wrote:
> > Thanks for the review!
> > Attached is v2 with feedback addressed.
>
> Your 0001 had already been pushed.
>
> I have pushed your 0002.
>
> I have also pushed the renaming of page -> block, dp -> page separately.
>   This should reduce the size of your 0003 a bit.
>
> Please produce an updated version of the 0003 page for further review.

Thanks for looking at this!
I have attached a patchset with only the code changes contained in the
previous patch 0003. I have broken the refactoring down into many
smaller pieces for ease of review.

- Melanie

Commits

Remove stray duplicated comment in heapam.h
- 9ed50ab3496f 16.0 landed
More refactoring of heapgettup() and heapgettup_pagemode()
- cfcf56f92398 16.0 landed
Run pgindent on heapam.c
- 009dbdea02d7 16.0 landed
Push lpp variable closer to usage in heapgetpage()
- e351f8541831 16.0 landed
Variable renaming in preparation for refactoring
- 8e1db29cdbbd 16.0 landed
Turn HeapKeyTest macro into inline function
- 4eb3b1120001 16.0 landed
Remove unused include
- c0f1e51ac79e 16.0 landed
Remove redundant breaks in HeapTupleSatisfiesVisibility
- c3652cd84ac8 16.0 landed