Re: pgsql: Consolidate docs for vacuum-related GUCs in new subsection
Melanie Plageman <melanieplageman@gmail.com>
From: Melanie Plageman <melanieplageman@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>,
Alvaro Herrera <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-01-13T15:22:15Z
Lists: pgsql-hackers
Thanks to Álvaro for pointing this out. I didn't think of it. On Sun, Jan 12, 2025 at 2:21 PM Tom Lane <tgl@sss.pgh.pa.us> wrote: > > Daniel Gustafsson <daniel@yesql.se> writes: > > On 11 Jan 2025, at 10:02, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote: > >> and the GUC grouping in guc_tables.c/h? > > > I don't know what our policy around this is, and maybe the backpatching hazard > > isn't too bad here, but it doesn't entirely seem worth the churn. > > I think the entire point of that categorization is to line up with the > docs, so our policy should be to fix this. I wrote a patch to reorder postgresql.conf.sample. But when I started looking at guc_tables.c, it doesn't seem like those are grouped according to the current docs order. Part of this is because some of the GUCs have different data types. But this appears to be more than that. For example, in master guc_tables.c, autovacuum_vacuum_cost_limit and vacuum_cost_limit are together (in docs in master they were in different sub-sections). Is guc_tables.c meant to be consistent with the ordering in the docs? - Melanie
Commits
-
Synchronize guc_tables.c categories with vacuum docs categories
- 2ae98ea5ab8f 18.0 landed
-
Reorder vacuum GUCs in postgresql.conf.sample to match docs
- af2317652d5d 18.0 landed
-
Consolidate docs for vacuum-related GUCs in new subsection
- ca9c6a5680d7 18.0 cited