Horton

Re: Eagerly scan all-visible pages to amortize aggressive vacuum

Melanie Plageman <melanieplageman@gmail.com>

View thread View on postgr.es
From: Melanie Plageman <melanieplageman@gmail.com>
To: Marcos Pegoraro <marcos@f10.com.br>
Cc: Alena Rybakina <a.rybakina@postgrespro.ru>, Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>, Nazir Bilal Yavuz <byavuz81@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Peter Geoghegan <pg@bowt.ie>, Robert Treat <rob@xzilla.net>
Date: 2025-01-15T20:55:52Z
Lists: pgsql-hackers

Attachments

On Wed, Jan 15, 2025 at 3:03 PM Melanie Plageman
<melanieplageman@gmail.com> wrote:
>
> On Wed, Jan 15, 2025 at 2:36 PM Marcos Pegoraro <marcos@f10.com.br> wrote:
> >>
> > There is a typo on committed vacuumlazy.c file
> >  * If the TID store fills up in phase I, vacuum suspends phase I, proceeds to
> >  * phases II and II, cleaning up the dead tuples referenced in the current TID
> >  * store. This empties the TID store resumes phase I.
> >
> > Probably you meant phases II and III
>
> Oops. Thanks for catching this. I'll fix that and the following
> sentence in the main patch proposed in this thread to avoid extra
> noise.

Attached v8 is rebased and has various comment cleanups.

- Melanie

Commits

  1. pg_stat_statements: Add counters for generic and custom plans

  2. Remove leftover mentions of XLOG_HEAP2_FREEZE_PAGE records

  3. Rename LVRelState->frozen_pages