Horton

Re: Log connection establishment timings

Melanie Plageman <melanieplageman@gmail.com>

View thread View on postgr.es
From: Melanie Plageman <melanieplageman@gmail.com>
To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Guillaume Lelarge <guillaume@lelarge.info>, Pg Hackers <pgsql-hackers@postgresql.org>, Daniel Gustafsson <daniel@yesql.se>, andrey.chudnovskiy@microsoft.com, Jelte Fennema-Nio <postgres@jeltef.nl>, Jacob Champion <jacob.champion@enterprisedb.com>
Date: 2025-03-04T22:47:26Z
Lists: pgsql-hackers 
On Mon, Mar 3, 2025 at 9:07 AM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> I did not imagine that much ;-) I was just seeing this code being duplicated
> and just thought about to avoid the duplication. But now that I read your comments
> above then I think we could just macro-ize the child_type check (as you mentioned
> up-thread). That would avoid the risk to forget to update the 3 locations doing the
> exact same check should we add a new child type in the game.

Is there a word we could use to describe what B_BACKEND and
B_WAL_SENDER have in common? They are the only backend types that will
go through the kind of external connection establishment steps (I
think), but I don't know a very accurate way to make that distinction
(which is required to come up with a useful macro name).

- Melanie

Commits

  1. Replace deprecated log_connections values in docs and tests