Horton

Re: Periodic FSM vacuum doesn't happen in one-pass strategy vacuum.

Melanie Plageman <melanieplageman@gmail.com>

View thread View on postgr.es
From: Melanie Plageman <melanieplageman@gmail.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>, Robert Haas <robertmhaas@gmail.com>, Peter Geoghegan <pg@bowt.ie>
Date: 2025-07-01T18:33:51Z
Lists: pgsql-hackers 
On Tue, Jul 1, 2025 at 12:01 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
>
> I've attached the updated patches for master and backbranches (v17 and
> v18). Please review these patches.

All look good to me. One nitpick that is up to you if you want to
change: the comment

 * Return the number of tuples deleted from the page during HOT pruning.

is at the top of the function block comment for lazy_scan_prune() in
your patch. Most of the function block comments in vacuumlazy.c list
the return value last after describing the other parameters and use
"Returns" as opposed to the imperative conjugation "Return".

Thanks so much for finding and fixing my bug!

- Melanie

Commits

  1. Fix missing FSM vacuum opportunities on tables without indexes.

  2. Optimize vacuuming of relations with no indexes.