Re: Log connection establishment timings

On Tue, Mar 4, 2025 at 4:40 AM Bertrand Drouvot
<bertranddrouvot.pg@gmail.com> wrote:
>
> On Mon, Mar 03, 2025 at 06:24:59PM -0500, Melanie Plageman wrote:
> >
> > And I think it would be even simpler to do your idea of groups and to
> > have aliases for different combinations of options. And it would let
> > us keep 'on' and 'off' as backwards compatibility aliases.
>
> hm, I think that's a very interesting idea. Being able to preserve backward
> compatibility is certainly a big bonus (as long as the values keep doing the
> exact same thing).
>
> > Maybe if I tried implementing it, it wouldn't work at all. But, as it
> > stands, I'm feeling nervous about making two of the most common GUCs
> > in the world (log_connections and log_disconnections) less structured.

I tried to mock up a prototype this morning of PGC_ENUM_LIST (or
PGC_SET, not sure what to call it) and actually parsing the enum list
input was easy to do, but there are a bunch of other things to figure
out that will take time.

Anyway, I'll start polishing the enum "on", "off", "timings" version
of my patch.

- Melanie