Horton

Re: remove bits* types

Melanie Plageman <melanieplageman@gmail.com>

View thread View on postgr.es
From: Melanie Plageman <melanieplageman@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Peter Eisentraut <peter@eisentraut.org>, Andres Freund <andres@anarazel.de>, Álvaro Herrera <alvherre@kurilemu.de>, Pg Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-03-30T16:41:09Z
Lists: pgsql-hackers 
On Thu, Mar 26, 2026 at 2:21 PM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> On Wed, Mar 25, 2026 at 05:27:34PM +0100, Peter Eisentraut wrote:
> > I'm mildly in favor of removing them.  But it appears there is no consensus.
>
> Same here.  While it still doesn't look like anybody is totally opposed to
> the idea, you are right that there is no consensus.

I really wish we would remove them. I want fewer confusing typedefs in
the code -- not more. I'm quite sad that as of 1bd6f22f43ac1b we are
now using them more widely (and publicly), and I feel that was done
without consensus. It should just use a regular uint32 -- like other
places we do this (e.g. scan_begin() amongst many others).

- Melanie

Commits

  1. Remove bits* typedefs.