Re: Logging parallel worker draught

Melanie Plageman <melanieplageman@gmail.com>

From: Melanie Plageman <melanieplageman@gmail.com>

To: Sami Imseih <samimseih@gmail.com>

Cc: Benoit Lobréau <benoit.lobreau@dalibo.com>, Tomas Vondra <tomas@vondra.me>, Guillaume Lelarge <guillaume@lelarge.info>, Alena Rybakina <a.rybakina@postgrespro.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>, "Imseih (AWS), Sami" <simseih@amazon.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Robert Haas <robertmhaas@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>

Date: 2025-04-07T16:41:24Z

Lists: pgsql-hackers

On Mon, Feb 3, 2025 at 12:37 AM Sami Imseih <samimseih@gmail.com> wrote:
>
> Besides that, I think this is ready for committer.

I started looking at this, and I like the idea.

A few comments: I don't understand what 0002 is. For starters, the
commit message says something about pg_stat_database, and there are no
changes related to that.

Also, we already have basically identical logging coming from
parallel_vacuum_process_all_indexes() and viewable in existing output.
Not only does your implementation not replace this, it is odd that
setting your new guc to none does not disable this. It seems a bit
inconsistent. I'm not sure what the exact right behavior is here,
though.

Since your last update, it seems parallel gin index build has been
committed, so perhaps you want to add that.

- Melanie