Re: Parallel Full Hash Join
Melanie Plageman <melanieplageman@gmail.com>
From: Melanie Plageman <melanieplageman@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Greg Nancarrow <gregn4422@gmail.com>,
Thomas Munro <thomas.munro@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>,
pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2021-07-30T20:34:34Z
Lists: pgsql-hackers
Attachments
- v7-0003-Parallel-Hash-Full-Right-Outer-Join.patch (text/x-patch) patch v7-0003
- v7-0001-Fix-race-condition-in-parallel-hash-join-batch-cl.patch (text/x-patch) patch v7-0001
- v7-0002-Improve-the-naming-of-Parallel-Hash-Join-phases.patch (text/x-patch) patch v7-0002
On Sat, Jul 10, 2021 at 9:13 AM vignesh C <vignesh21@gmail.com> wrote: > > On Mon, May 31, 2021 at 10:47 AM Greg Nancarrow <gregn4422@gmail.com> wrote: > > > > On Sat, Mar 6, 2021 at 12:31 PM Thomas Munro <thomas.munro@gmail.com> wrote: > > > > > > On Tue, Mar 2, 2021 at 11:27 PM Thomas Munro <thomas.munro@gmail.com> wrote: > > > > On Fri, Feb 12, 2021 at 11:02 AM Melanie Plageman > > > > <melanieplageman@gmail.com> wrote: > > > > > I just attached the diff. > > > > > > > > Squashed into one patch for the cfbot to chew on, with a few minor > > > > adjustments to a few comments. > > > > > > I did some more minor tidying of comments and naming. It's been on my > > > to-do-list to update some phase names after commit 3048898e, and while > > > doing that I couldn't resist the opportunity to change DONE to FREE, > > > which somehow hurts my brain less, and makes much more obvious sense > > > after the bugfix in CF #3031 that splits DONE into two separate > > > phases. It also pairs obviously with ALLOCATE. I include a copy of > > > that bugix here too as 0001, because I'll likely commit that first, so > > > I rebased the stack of patches that way. 0002 includes the renaming I > > > propose (master only). Then 0003 is Melanie's patch, using the name > > > SCAN for the new match bit scan phase. I've attached an updated > > > version of my "phase diagram" finger painting, to show how it looks > > > with these three patches. "scan*" is new. > > > > Patches 0002, 0003 no longer apply to the master branch, seemingly > > because of subsequent changes to pgstat, so need rebasing. > > I am changing the status to "Waiting on Author" as the patch does not > apply on Head. > > Regards, > Vignesh > > Rebased patches attached. I will change status back to "Ready for Committer"
Commits
-
Remove overzealous assertion from PHJ.
- b37d051b0e59 16.0 landed
-
Remove comment obsoleted by 11c2d6fd.
- f303ec6210c4 16.0 landed
-
Parallel Hash Full Join.
- 11c2d6fdf5af 16.0 landed
-
Improve the naming of Parallel Hash Join phases.
- 8fba928fd788 16.0 landed
-
Update the names of Parallel Hash Join phases.
- 378802e3713c 14.0 landed
-
Add BarrierArriveAndDetachExceptLast().
- 7888b0999488 14.0 landed
-
Mop-up for wait event naming issues.
- 3048898e73c7 13.0 cited
-
Push tuple limits through Gather and Gather Merge.
- 3452dc5240da 11.0 cited