Re: Support logical replication of DDLs

Zheng Li <zhengli10@gmail.com>

From: Zheng Li <zhengli10@gmail.com>
To: "Takamichi Osumi (Fujitsu)" <osumi.takamichi@fujitsu.com>
Cc: Ajin Cherian <itsajin@gmail.com>, Runqi Tian <runqidev@gmail.com>, vignesh C <vignesh21@gmail.com>, Peter Smith <smithpb2250@gmail.com>, li jie <ggysxcq@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Amit Kapila <amit.kapila16@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Japin Li <japinli@hotmail.com>, rajesh singarapu <rajesh.rs0541@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-03-17T15:40:56Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add a run_as_owner option to subscriptions.

  2. Refactor pgoutput_change().

  3. Print the correct aliases for DML target tables in ruleutils.

  4. Fix object identity string for transforms

  5. Add grantable MAINTAIN privilege and pg_maintain role.

  6. Get rid of recursion-marker values in enum AlterTableType

  7. Release cache tuple when no longer needed

  8. Empty search_path in logical replication apply worker and walsender.

  9. Refactor format_type APIs to be more modular

  10. Use wrappers of PG_DETOAST_DATUM_PACKED() more.

Attachments

On Fri, Mar 17, 2023 at 10:49 AM Takamichi Osumi (Fujitsu)
<osumi.takamichi@fujitsu.com> wrote:
>
> Hi
>
> On Tuesday, March 14, 2023 1:17 PM Ajin Cherian <itsajin@gmail.com> wrote:
> > I found out that the option ONLY was not parsed in the "CREATE INDEX"
> > command, for eg: CREATE UNIQUE INDEX ... ON ONLY table_name ...
> >
> > I've fixed this in patch 0002.
> FYI, cfbot reports a failure of v80 on linux [1]. Could you please check ?
>
>
> [17:39:49.745] ============== running regression test queries        ==============
> [17:39:49.745] test test_ddl_deparse             ... ok           27 ms
> [17:39:49.745] test create_extension             ... ok           60 ms
> [17:39:49.745] test create_schema                ... ok           28 ms
> [17:39:49.745] test aggregate                    ... ok           19 ms
> [17:39:49.745] test create_table                 ... FAILED      245 ms
> [17:39:49.745] test constraints                  ... FAILED      420 ms
> [17:39:49.745] test alter_table                  ... FAILED      448 ms
> [17:39:49.745] ============== shutting down postmaster               ==============
> [17:39:49.745]
> [17:39:49.745] ======================
> [17:39:49.745]  3 of 7 tests failed.
> [17:39:49.745] ======================
> [17:39:49.745]
> [17:39:49.745] The differences that caused some tests to fail can be viewed in the
> [17:39:49.745] file "/tmp/cirrus-ci-build/src/test/modules/test_ddl_deparse_regress/regression.diffs".  A copy of the test summary that you see
> [17:39:49.745] above is saved in the file "/tmp/cirrus-ci-build/src/test/modules/test_ddl_deparse_regress/regression.out".
>

Hi,

I've updated the failing test output in the attached patch set.

Regards,
Zane