Horton
Menu

Re: Row pattern recognition

Henson Choi <assam258@gmail.com>

View thread
From: Henson Choi <assam258@gmail.com>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: jacob.champion@enterprisedb.com, david.g.johnston@gmail.com, vik@postgresfriends.org, er@xs4all.nl, peter@eisentraut.org, pgsql-hackers@postgresql.org
Date: 2026-01-17T08:33:28Z
Lists: pgsql-hackers 
2026년 1월 17일 (토) 17:19, Tatsuo Ishii <ishii@postgresql.org>님이 작성:

> Hi Henson,
>
> > I'm now reviewing the remaining parts: pattern optimization in planner,
> > absorption function, and step function. Once the review is complete,
> > I'll send the rest of the patches.
>
> I am reviewing the test cases and found this:
>
> SELECT * FROM (SELECT 1 AS x) t
>  WINDOW w AS (
>  ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING
>  PATTERN (a b c d e f g h i j k l m n o p q r s t u v w x y z aa)
>  DEFINE a AS TRUE
> );
> ERROR:  number of row pattern definition variable names exceeds 26
>
> I thought you have eliminated the 26 variables limit. If so, related
> codes using WindowClause->defineInitial should be removed. Shall I do
> that? Or you want to do that while refactoring?
>


Already found and cleaned up.
Will include it in the next patch.​​​​​​​​​​​​​​​​


> Best regards,
> --
> Tatsuo Ishii
> SRA OSS K.K.
> English: http://www.sraoss.co.jp/index_en/
> Japanese:http://www.sraoss.co.jp
>

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust cross-version upgrade tests for seg_out() fix

  2. Rationalize error comments in partition split/merge tests

  3. Add fast path for foreign key constraint checks

  4. Fix assorted pretty-trivial memory leaks in the backend.

  5. Add temporal FOREIGN KEY contraints

  6. Add trailing commas to enum definitions

  7. Remove obsolete executor cleanup code