Re: Row pattern recognition

Henson Choi <assam258@gmail.com>

From: Henson Choi <assam258@gmail.com>

To: jian he <jian.universality@gmail.com>

Cc: Tatsuo Ishii <ishii@postgresql.org>, pgsql-hackers@postgresql.org, zsolt.parragi@percona.com, sjjang112233@gmail.com, vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com, david.g.johnston@gmail.com, peter@eisentraut.org, li.evan.chao@gmail.com

Date: 2026-06-24T07:45:13Z

Lists: pgsql-hackers

Hi jian,

Thanks -- this is a clean improvement, no objections. Honestly this part of
the
parser is an area where you read it better than I do, so I'm glad to defer
to
you here. Quick notes inline.

> The above comments can be deleted, ParseRPRNavCall, ParseFuncOrColumn
> already have lots of comments.
> Also the error check and its message are quite intuitive in
ParseRPRNavCall.

Agreed.

> So, I tended to use coerce_to_target_type.

Agreed.

> ParseRPRNavCall ending can be simplified because coerce_to_target_type
> can handle the same data type.
> Therefore, `if (offtype != INT8OID)` is not necessary.

Agreed.

> Drop the extra parentheses around ereport() argument lists, fewer
> parentheses are always better for new code.

Agreed.

Tatsuo, this one looks good to take whenever you like.

Best,
Henson

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Adjust cross-version upgrade tests for seg_out() fix
- 3e3d7875e956 19 (unreleased) cited
Rationalize error comments in partition split/merge tests
- ecb2508aaf9b 19 (unreleased) cited
Add fast path for foreign key constraint checks
- 2da86c1ef9b5 19 (unreleased) cited
Fix assorted pretty-trivial memory leaks in the backend.
- e78d1d6d47dc 19 (unreleased) cited
Add temporal FOREIGN KEY contraints
- 89f908a6d0ac 18.0 cited
Add trailing commas to enum definitions
- 611806cd726f 17.0 cited
Remove obsolete executor cleanup code
- d060e921ea5a 17.0 cited