Horton

Re: Row pattern recognition

Henson Choi <assam258@gmail.com>

View thread
From: Henson Choi <assam258@gmail.com>
To: Tatsuo Ishii <ishii@postgresql.org>, jian.universality@gmail.com
Cc: zsolt.parragi@percona.com, sjjang112233@gmail.com, vik@postgresfriends.org, er@xs4all.nl, jacob.champion@enterprisedb.com, david.g.johnston@gmail.com, peter@eisentraut.org, li.evan.chao@gmail.com, pgsql-hackers@postgresql.org
Date: 2026-05-05T09:15:29Z
Lists: pgsql-hackers 
Hi Tatsuo, Jian,

Both coding-style items from Jian's review will be addressed and
included in the next patch series.

> 1. We need to add trailing commas to enum definitions. See
> >
> https://git.postgresql.org/cgit/postgresql.git/commit/?id=611806cd726fc92989ac918eac48fd8d684869c7
>
> I forgot that. Thanks for reminding.
>

Three enum types introduced by the patch lack a trailing comma on the
last enumerator: RPRNavKind, RPRNavOffsetKind, and RPRPatternNodeType.
All three will be corrected in the next series.


> > + (errcode(ERRCODE_SYNTAX_ERROR),
> > The leading parenthesis is optional and can be removed, fewer
> > parentheses are always better.
> > See related discussion:
> > https://postgr.es/m/202510100916.s2e6n3xiwvyc@alvherre.pgsql
>
> Right. I will review all other patches.


The outer-parentheses pattern appears in 17 ereport() calls in
parse_rpr.c and 2 in optimizer/plan/rpr.c.  All 19 sites will be
cleaned up in the next series.

Jian, I will review your other patches as well.

Best,
Henson