Re: BUG #19354: JOHAB rejects valid byte sequences
Henson Choi <assam258@gmail.com>
From: Henson Choi <assam258@gmail.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Robert Haas <robertmhaas@gmail.com>,
Tom Lane <tgl@sss.pgh.pa.us>, Jeroen Vermeulen <jtvjtv@gmail.com>, VASUKI M <vasukianand0119@gmail.com>, pgsql-bugs@lists.postgresql.org
Date: 2026-04-15T05:57:50Z
Lists: pgsql-bugs
Attachments
Subject: Fix and expand comments for Korean encodings in encnames.c
Hi hackers,
While reading through the encoding alias table in src/common/encnames.c,
I noticed a few long-standing inaccuracies and omissions in the per-entry
comments for the three Korean encodings.
The most visible issue is the JOHAB entry, whose comment describes it as
"Extended Unix Code for simplified Chinese" -- apparently a copy/paste
slip from a neighboring EUC entry. JOHAB is in fact the Korean
combining-style encoding defined in KS X 1001 annex 3.
The attached 0002 patch makes comment-only adjustments to the three
Korean encodings:
* JOHAB: replace the incorrect "simplified Chinese" description with
a correct one that identifies it as the Korean combining (Johab)
encoding standardized in KS X 1001 annex 3.
* EUC_KR: drop a stray space before the comma in the existing
comment, and note that the encoding covers the KS X 1001
precomposed (Wansung) form.
* UHC: spell out "Unified Hangul Code", clarify that it is
Microsoft Windows CodePage 949, and describe its relationship to
EUC-KR (superset covering all 11,172 precomposed Hangul syllables).
No behavior change, no catalog change, no pg_wchar.h change -- this
touches comments in src/common/encnames.c only. pgindent is clean.
Thanks,
Henson Choi
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix comments for Korean encodings in encnames.c
- e5fb1ff5bed9 14.23 landed
- 78f8fbc8ab5f 15.18 landed
- 5ef61f417f17 16.14 landed
- ec61832231c4 17.10 landed
- ea94d2e6734e 18.4 landed
- 9a618901a476 19 (unreleased) landed
-
Fix the inadvertent libpq ABI breakage discovered by Martin Pitt: the
- 8468146b03c8 8.3.0 cited
-
> Tatsuo Ishii wrote:
- a8bd7e1c6e02 7.3.1 cited