Horton
Menu

Re: Row pattern recognition

Henson Choi <assam258@gmail.com>

View thread
From: Henson Choi <assam258@gmail.com>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: jacob.champion@enterprisedb.com, david.g.johnston@gmail.com, vik@postgresfriends.org, er@xs4all.nl, peter@eisentraut.org, pgsql-hackers@postgresql.org
Date: 2026-02-05T00:46:06Z
Lists: pgsql-hackers

Attachments

Hi Tatsuo,

> Therefore, I believe it only makes sense to add explicit initialization
> > for nfaStatesActive and nfaContextsActive, since these are the only two
> > that release_partition() also explicitly resets.
>
> That makes sense.
>

Thank you for confirming.

> ## Proposal for consistency
> >
> >   /* Initialize NFA free lists for row pattern matching */
> >   winstate->nfaContext = NULL;
> >   winstate->nfaContextTail = NULL;
> >   winstate->nfaContextFree = NULL;
> >   winstate->nfaStateFree = NULL;
> >   winstate->nfaLastProcessedRow = -1;
> >   winstate->nfaStatesActive = 0;        // Add this
> >   winstate->nfaContextsActive = 0;      // Add this
> >
> > Would you like me to include this change in the next patch?
>
> Yes, please.
>


Done. Please see the attached patch.

Best regards,
Henson

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Adjust cross-version upgrade tests for seg_out() fix

  2. Rationalize error comments in partition split/merge tests

  3. Add fast path for foreign key constraint checks

  4. Fix assorted pretty-trivial memory leaks in the backend.

  5. Add temporal FOREIGN KEY contraints

  6. Add trailing commas to enum definitions

  7. Remove obsolete executor cleanup code