Horton

Re: pg_ctl start may return 0 even if the postmaster has been already started on Windows

Yasir <yasir.hussain.shah@gmail.com>

View thread View on postgr.es
From: Yasir <yasir.hussain.shah@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: 2024-07-16T12:04:31Z
Lists: pgsql-hackers 
On Tue, Jul 16, 2024 at 4:58 PM Yasir Shah <yasir.hussain.shah@gmail.com>
wrote:

> The following review has been posted through the commitfest application:
> make installcheck-world:  tested, failed         (meson test, passed)
> Implements feature:       tested, failed            (tested, passed)
> Spec compliant:           not tested                   (tested, passed
> with suggestion)
> Documentation:            not tested
>

Please ignore the above 4 lines in my review. See my comments in blue.


> Hi,
>
> I have verified following:
>   - Bug exits in PG17. I also checked it in PG16 but it does not exits
> there.
>   - After applying your patch, I can confirm that bug get fixed.
>   - no regression found. I ran "meson test".
>   - I would like to suggest you that #includes should be included at
> appropriate location keeping the #includes alphabetically sorted, what I
> observed in the PG code as a standard:
>     Your patch:
>     #include <versionhelpers.h>
>     #include <tlhelp32.h>
>
>     It should be like:
>     #include <tlhelp32.h>
>     #include <versionhelpers.h>
>
> Regards...
>
>
> Yasir Hussain
> Bitnine Global Inc.

Commits

  1. Re-enable autoruns for cmd.exe on Windows

  2. Re-enable autoruns for for cmd.exe on Windows

  3. pg_regress: Disable autoruns for cmd.exe on Windows

  4. pg_ctl: Disable autoruns for cmd.exe on Windows