Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

Robert Sjöblom <robert.sjoblom@fortnox.se>

From: Robert Sjöblom <robert.sjoblom@fortnox.se>
To:
Cc: pgsql-hackers@lists.postgresql.org
Date: 2023-05-16T13:01:52Z
Lists: pgsql-hackers

Attachments

Den tis 16 maj 2023 kl 01:44 skrev Peter Smith <smithpb2250@gmail.com>:
>
> On Mon, May 15, 2023 at 11:36 PM Robert Sjöblom
> <robert.sjoblom@fortnox.se> wrote:
> >
> >
> >
> > On 2023-05-05 15:17, Robert Sjöblom wrote:
> > >
> > > Hi,
> > >
> > > We have recently used the PostgreSQL documentation when setting up our
> > > logical replication. We noticed there was a step missing in the
> > > documentation on how to drop a logical replication subscription with a
> > > replication slot attached.
> >
> > Following discussions, please see revised documentation patch.
> >
>
> LGTM.
>
> BTW, in the previous thread, there was also a suggestion from Amit [1]
> to change the errhint in a similar way. There was no reply to Amit's
> idea, so it's not clear whether it's an accidental omission from your
> v2 patch or not.
>
> ------
> [1] https://www.postgresql.org/message-id/CAA4eK1J11phiaoCOmsjNqPZ9BOWyLXYrfgrm5vU2uCFPF2kN1Q%40mail.gmail.com
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia

Accidental omission by way of mail client, I suppose -- some messages
got flagged as spam and moved to another folder. I went ahead with
Masahiko Sawada's suggestion for the error message; see revised patch.

Best regards,
Robert Sjöblom

-- 
Innehållet i detta e-postmeddelande är konfidentiellt och avsett endast för 
adressaten.Varje spridning, kopiering eller utnyttjande av innehållet är 
förbjuden utan tillåtelse av avsändaren. Om detta meddelande av misstag 
gått till fel adressat vänligen radera det ursprungliga meddelandet och 
underrätta avsändaren via e-post

Commits

  1. Fix the errhint message and docs for drop subscription failure.

  2. doc: Add more details about pg_stat_get_xact_blocks_{fetched,hit}

  3. Doc: mention CREATE+ATTACH PARTITION with CREATE TABLE...PARTITION OF.