Re: [PATCH] Clear up perlcritic 'missing return' warning
Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Mike Blackwell <maiku41@gmail.com>, Michael Paquier <michael@paquier.xyz>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2018-05-23T18:00:18Z
Lists: pgsql-hackers
On Wed, May 23, 2018 at 1:45 PM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote: > On 2018-May-23, Andrew Dunstan wrote: > >> And yes, the idea is that if we do this then we adopt a perlcritic >> policy that calls it out when we forget. > > If we can have a buildfarm animal that runs perlcritic that starts green > (and turns yellow with any new critique), with a config that's also part > of our tree, so we can easily change it as we see fit, it should be > good. > Should be completely trivial to do. We already have the core infrastructure - I added it a week or two ago. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Commits
-
Don't fall off the end of perl functions
- 3a7cc727c7c5 11.0 landed