Re: pg_dump bug for extension owned tables

On Thu, Aug 6, 2020 at 4:12 PM Fabrízio de Royes Mello
<fabriziomello@gmail.com> wrote:
>
>
> On Mon, Jul 13, 2020 at 6:18 PM Fabrízio de Royes Mello <fabriziomello@gmail.com> wrote:
>>
>>
>> On Mon, Jul 13, 2020 at 5:05 PM Andrew Dunstan <andrew.dunstan@2ndquadrant.com> wrote:
>> >
>> >
>> > On 7/13/20 2:46 PM, Fabrízio de Royes Mello wrote:
>> > >
>> > >
>> > > >
>> > > > yeah, that's the fix I came up with too. The only thing I added was
>> > > > "Assert(tbinfo->attgenerated);" at about line 2097.
>> > > >
>> > >
>> > > Cool.
>> > >
>> > > >
>> > > > Will wait for your TAP tests.
>> > > >
>> > >
>> > > Actually I've sent it already but it seems to have gone to the
>> > > moderation queue.
>> > >
>> > > Anyway attached with your assertion and TAP tests.
>> > >
>> > >
>> >
>> >
>> >
>> > Thanks, that all seems fine. The TAP test changes are a bit of a pain in
>> > the neck before release 11, so I think I'll just do those back that far,
>> > but the main fix for all live branches.
>> >
>>
>> Sounds good to me.
>>
>
> Just added to the next commitfest [1] to make sure we'll not lose it.
>
> Regards,
>
> [1] https://commitfest.postgresql.org/29/2671/
>


Thanks, Committed. Further investigation shows this was introduced in
release 12, so that's how far back I went.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services