Re: [PATCH] Increase the maximum value track_activity_query_size

Andrew Dunstan <andrew.dunstan@2ndquadrant.com>

From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Treat <rob@xzilla.net>, Robert Haas <robertmhaas@gmail.com>, Nikolay Samokhvalov <samokhvalov@gmail.com>, Michael Paquier <michael@paquier.xyz>, Bruce Momjian <bruce@momjian.us>, Alexey Kondratov <a.kondratov@postgrespro.ru>, v.makarov@postgrespro.ru, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-12-31T01:47:08Z
Lists: pgsql-hackers
On Tue, Dec 31, 2019 at 11:16 AM Tomas Vondra
<tomas.vondra@2ndquadrant.com> wrote:
>
> On Tue, Dec 31, 2019 at 10:25:26AM +1030, Andrew Dunstan wrote:
> >On Tue, Dec 31, 2019 at 10:16 AM Andrew Dunstan
> ><andrew.dunstan@2ndquadrant.com> wrote:
> >>
> >> On Tue, Dec 31, 2019 at 9:38 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >>
> >> >
> >> > This doesn't seem like a reason not to allow a higher limit, like a
> >> > megabyte or so, but I'm not sure that pushing it to the moon would be
> >> > wise.
> >> >
> >>
> >>
> >> Just to get a mental handle on the size of queries we might be
> >> allowing before truncation, I did some very rough arithmetic on what
> >> well known texts might fit in a megabyte. By my calculations you could
> >> fit about four Animal Farms or one Madame Bovary in about a megabyte.
> >> So I think that seems like more than enough :-). (My mind kinda
> >> explores at the thought of debugging a query as long as Animal Farm.)
> >>
> >
> >
> >Turns out my arithmetic was a bit off. Animal Farm is 90 kb, Madame
> >Bovary 678 Kb.
> >
>
> Not sure, but the Animal Farm text I found is about ~450kB (~120 pages,
> with ~3kB per page) ...


My browser has led me astray.
http://gutenberg.net.au/ebooks01/0100011.txt is in fact 172618 bytes.

cheers

andrew


-- 
Andrew Dunstan                https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



Commits

  1. Increase the maximum value of track_activity_query_size.