Horton

Re: [BUG] temporary file usage report with extended protocol and unnamed portals

Sami Imseih <samimseih@gmail.com>

View thread View on postgr.es
From: Sami Imseih <samimseih@gmail.com>
To: Mircea Cadariu <cadariu.mircea@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Frédéric Yhuel <frederic.yhuel@dalibo.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Benoit Lobréau <benoit.lobreau@dalibo.com>, Guillaume Lelarge <guillaume.lelarge@dalibo.com>, Pierrick Chovelon <pierrick.chovelon@dalibo.com>
Date: 2025-09-17T15:52:31Z
Lists: pgsql-hackers 
> One argument for keeping the tests would be that they nicely bring together the side-effect (logging) and these use-cases, whereas in the code they're pretty distant, making the connection not obvious.

Another argument is that we have no coverage on temp logging, which
is why this bug was discovered. There are likely plenty of tools
out there, for example pgbadger or manual log analysis, that
have probably misinterpreted temporary usage all this time,
because of the way the data was emitted.

--
Sami

Commits

  1. Drop unnamed portal immediately after execution to completion

  2. Override log_error_verbosity to "default" in test 009_log_temp_files

  3. Add tests for logging of temporary file removal and statement