Re: [Proposal] Adding callback support for custom statistics kinds
Sami Imseih <samimseih@gmail.com>
From: Sami Imseih <samimseih@gmail.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-12-09T21:54:58Z
Lists: pgsql-hackers
Attachments
- v6-0001-Allow-cumulative-statistics-to-serialize-auxiliar.patch (application/octet-stream)
> My point is that, there are many places jumping to “error”, then from “error” goto “done”, > if an error didn’t happen from the deserialize callback, how end_extra_stats() > can know if failure happened and takes action accordingly? IIUC, if *any* error occurs outside of a deserialize callback, first the "error" code will be called, followed by "done" which will then trigger the end_extra_stats callback that will perform the cleanup. Attached is v6 with a few minor indentation fixes and a correction to freeing the file in the cleanup callback. -- Sami Imseih Amazon Web Services (AWS)