Re: making EXPLAIN extensible

Sami Imseih <samimseih@gmail.com>

From: Sami Imseih <samimseih@gmail.com>

To: Robert Haas <robertmhaas@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Jeff Davis <pgsql@j-davis.com>, Thom Brown <thom@linux.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-03-19T17:41:36Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

pg_overexplain: Use PG_MODULE_MAGIC_EXT.
- 83ccc85859f3 18.0 landed
pg_overexplain: Call previous hooks as appropriate.
- 9f0c36aea0fb 18.0 landed
pg_overexplain: Additional EXPLAIN options for debugging.
- 8d5ceb113e3f 18.0 landed
Add an additional hook for EXPLAIN option validation.
- 50ba65e73325 18.0 landed
Add some new hooks so extensions can add details to EXPLAIN.
- 4fd02bf7cf94 18.0 landed
Make it possible for loadable modules to add EXPLAIN options.
- c65bc2e1d14a 18.0 landed

Attachments

v3-0001-Add-new-hooks-for-performing-additional-EXPLAIN-o.patch (application/octet-stream) patch v3-0001

> On Wed, Mar 19, 2025 at 11:38 AM Sami Imseih <samimseih@gmail.com> wrote:
> > ... as I made the hook signature match that of
> > ParseExplainOptionList, so both pstate and the options list
> > are now available to the hook.
>
> This version LGTM, except it's not pgindent-clean.

ugh, sorry about that. ran it for both modified files and it found one
indentation correction from v2.

> index 1d4be3c18ac..8fe1ca5c73e 100644
38c38
< +        (*explain_validate_options_hook) (es, options, pstate);
---
> +        (*explain_validate_options_hook)(es, options, pstate);
59c59
< 2.47.1

v3 attached.


--
Sami Imseih
Amazon Web Services (AWS)