Re: test_autovacuum/001_parallel_autovacuum is broken

Sami Imseih <samimseih@gmail.com>

From: Sami Imseih <samimseih@gmail.com>

To: Masahiko Sawada <sawada.mshk@gmail.com>

Cc: Alexander Lakhin <exclusion@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>, Daniil Davydov <3danissimo@gmail.com>

Date: 2026-04-09T18:32:33Z

Lists: pgsql-hackers

Attachments

v1-0001-Fix-unstable-log_contains-in-parallel-autovacuum-.patch (application/octet-stream) patch v1-0001

> The root cause seems to me that it's not guaranteed that we can see
> the autovacuum logs after checking the statistics (i.e.,
> pg_stat_user_tables) as we update the statistics and then write the
> log.
>
> One way to fix the test is to replace log_contains() with
> wait_for_log(). We can also remove wait_for_autovacuum_complete()
> logic altogether.

+1. I was going to reply with exactly this. Attached is the fix.

--
Sami

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix unstable log verification in test_autovacuum.
- c22d115f1d13 19 (unreleased) landed
Remove an unstable wait from parallel autovacuum regression test.
- 8030b839d3d2 19 (unreleased) landed