Horton
Menu

Re: PgStat_HashKey padding issue when passed by reference

Sami Imseih <samimseih@gmail.com>

View thread
From: Sami Imseih <samimseih@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-09-20T01:52:24Z
Lists: pgsql-hackers 
> On Thu, Sep 18, 2025 at 11:52:05AM -0500, Sami Imseih wrote:
> > v2 looks good to me. Not sure if there are edge cases in which
> > the assert will succeed even with padding (I can't think of any way
> > that will be possible),  so for now what you have seems good enough.
>
> Okay, I've applied that on HEAD, then.  I didn't see an urge in
> backpatching it.  If there is an ask to do so, I could always do so
> later.
> --
> Michael

Thank you! I update the CF entry [0] as committed.

[0] https://commitfest.postgresql.org/patch/6033/

--
Sami

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Document and check that PgStat_HashKey has no padding