Re: Regression in statement locations
Sami Imseih <samimseih@gmail.com>
From: Sami Imseih <samimseih@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: David Steele <david@pgbackrest.org>,
Pg Hackers <pgsql-hackers@postgresql.org>, Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>,
jian he <jian.universality@gmail.com>
Date: 2025-05-19T22:10:14Z
Lists: pgsql-hackers
> It is also possible that the regression is not coming from
> 499edb0 but I do not see another obvious candidate.
I used pg_stat_statements to repro the issue, and a bisect
resulted in 499edb0 being the source of the regression.
```
select pg_stat_statements_reset();
set pg_stat_statements.track='all';
DO $$
DECLARE
BEGIN
EXECUTE 'CREATE TABLE do_table (weird_name INT); DROP table do_table';
END $$;
select query from pg_stat_statements where not toplevel;
```
WITHOUT a semicolon at the end of the statements, as reported by David
```
EXECUTE 'CREATE TABLE do_table (weird_name INT); DROP table do_table';
```
I can reproduce the issue
query
-------------------------------------------------------------
CREATE TABLE do_table (weird_name INT); DROP table do_table
CREATE TABLE do_table (weird_name INT)
(2 rows)
WITH a semicolon at the end of the statements
```
EXECUTE 'CREATE TABLE do_table (weird_name INT); DROP table do_table;';
```
I cannot reproduce the issue
query
----------------------------------------
DROP table do_table
CREATE TABLE do_table (weird_name INT)
(2 rows)
I am still not sure why this is the case, but wanted to share this
for now.
--
Sami Imseih
Amazon Web Services (AWS)
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix regression with location calculation of nested statements
- 06450c7b8c70 18.0 landed