Horton

Re: [BUG] temporary file usage report with extended protocol and unnamed portals

Sami Imseih <samimseih@gmail.com>

View thread View on postgr.es
From: Sami Imseih <samimseih@gmail.com>
To: Mircea Cadariu <cadariu.mircea@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Frédéric Yhuel <frederic.yhuel@dalibo.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Benoit Lobréau <benoit.lobreau@dalibo.com>, Guillaume Lelarge <guillaume.lelarge@dalibo.com>, Pierrick Chovelon <pierrick.chovelon@dalibo.com>
Date: 2025-09-19T12:50:09Z
Lists: pgsql-hackers 
> The "everything" also includes the query_text.
>
> This makes me wonder then if all it takes is just adding this to PortalDrop (proposed earlier in the thread by Frédéric):

One thing I did not like about that approach is that we will need to
save the current debug_query_string inside PortalDrop before
temporarily setting it to the one from the about to be dropped
portal, and then set it back to the saved one before exiting.
Otherwise, we might end up logging the wrong query in some cases
(although I could not find a test case that proves my worry).

With v12, drop_unnamed_portal sets the debug_query_string of the
portal, and we know right after drop_unnamed_portal is completed
the debug_query_string is set to the current query.

--
Sami

Commits

  1. Drop unnamed portal immediately after execution to completion

  2. Override log_error_verbosity to "default" in test 009_log_temp_files

  3. Add tests for logging of temporary file removal and statement