Re: Logging parallel worker draught

Sami Imseih <samimseih@gmail.com>

From: Sami Imseih <samimseih@gmail.com>

To: Benoit Lobréau <benoit.lobreau@dalibo.com>

Cc: Tomas Vondra <tomas@vondra.me>, Guillaume Lelarge <guillaume@lelarge.info>, Alena Rybakina <a.rybakina@postgrespro.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>, "Imseih (AWS), Sami" <simseih@amazon.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Robert Haas <robertmhaas@gmail.com>, Amit Kapila <amit.kapila16@gmail.com>, Melanie Plageman <melanieplageman@gmail.com>, "Andrey M. Borodin" <x4mmm@yandex-team.ru>

Date: 2025-02-03T05:36:52Z

Lists: pgsql-hackers

Attachments

v8-0002-Setup-counters-for-parallel-vacuums.patch (application/octet-stream) patch v8-0002
v8-0001-Add-a-guc-for-parallel-worker-logging.patch (application/octet-stream) patch v8-0001
v8-0003-Implements-logging-for-parallel-worker-usage-in-u.patch (application/octet-stream) patch v8-0003
v8-0004-Implements-logging-for-parallel-worker-usage-in-q.patch (application/octet-stream) patch v8-0004

> The "story" I have in mind is: I need to audit an instance I know
> nothing about. I ask the client to adapt the logging parameters for
> pgbadger (including this one), collect the logs and generate a report
> for the said period to have a broad overview of what is happenning.

Let's see if anyone has a different opinion.

As far as the current set of patches, I had some other changes that
I missed earlier; indentation to the calls in LogParallelWorkersIfNeeded
and comment for the LogParallelWorkersIfNeeded function. I also re-worked the
setup of the GUC as it was not setup the same way as other
GUCs with an options list. I ended up just making those changes
in v8.

Besides that, I think this is ready for committer.

Regards,

Sami