Horton

Re: [BUG] temporary file usage report with extended protocol and unnamed portals

Sami Imseih <samimseih@gmail.com>

View thread View on postgr.es
From: Sami Imseih <samimseih@gmail.com>
To: Mircea Cadariu <cadariu.mircea@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Guillaume Lelarge <guillaume.lelarge@dalibo.com>, Frédéric Yhuel <frederic.yhuel@dalibo.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Benoit Lobréau <benoit.lobreau@dalibo.com>, Pierrick Chovelon <pierrick.chovelon@dalibo.com>
Date: 2025-10-29T21:58:22Z
Lists: pgsql-hackers

Attachments

> > v16 is based on [0], with updates to the documentation and tests.
>
> Thanks for the updated patch!
>
> > +ok( $node->log_contains(qr/STATEMENT:\s+SELECT a FROM foo ORDER BY a
> > OFFSET \$1/s, $log_offset),
> >      "bind and implicit transaction, no statement logged");
> Should it actually be "statement correctly logged" instead of "no
> statement logged"?

oops, you're right.

We can actually remove "temporary file removed"
and "no statement logged" since we expect the
logging to blame the correct query in all these cases.

See v17

--
Sami Imseih
Amazon Web Services (AWS)

Commits

  1. Drop unnamed portal immediately after execution to completion

  2. Override log_error_verbosity to "default" in test 009_log_temp_files

  3. Add tests for logging of temporary file removal and statement