Re: query_id: jumble names of temp tables for better pg_stat_statement UX
Sami Imseih <samimseih@gmail.com>
From: Sami Imseih <samimseih@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Christoph Berg <myon@debian.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
ma lz <ma100@hotmail.com>
Date: 2025-03-25T04:30:24Z
Lists: pgsql-hackers, pgsql-general
> Exactly. Like Tom I'm not really worried about the proposal, but of > course I could prove to be wrong. I am ready to assume that bloat in > pgss entries caused by temp tables is a more common case. I ran installcheck-parallel with the patch and without the patch 3x, and the reduction in pg_s_s bloat is visible. The same entries are reused even when the regression database is recreated, as expected. ## without patch run installcheck-parallel 3 times postgres=# select count(distinct queryid), count(*) from pg_stat_statements; count | count -------+------- 41630 | 74776 (1 row) ## with patch run installcheck-parallel 3 times postgres=# select count(distinct queryid), count(*) from pg_stat_statements; count | count -------+------- 26301 | 73030 (1 row) >This part of the thread is digressing, but I'd on the side of removing > entirely the GUC and make the grouping of IN values the default. We > still have time to discuss that during the beta cycle, so let's do so > on its related thread. I will do that tomorrow in that thread. It would not make sense to introduce a GUC for that behavior and not for this. So, I am glad we discussed this here. Looking at the patches, I could not find anything else besides what was pointed out by Christoph earlier. -- Sami Imseih Amazon Web Services (AWS)
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Use relation name instead of OID in query jumbling for RangeTblEntry
- 787514b30bb7 18.0 landed
-
Fix two issues with custom_query_jumble in gen_node_support.pl
- 27ee6ede6bc9 18.0 landed
-
pg_stat_statements: Add more tests with temp tables and namespaces
- 3430215fe35f 18.0 landed
-
Add support for custom_query_jumble as a node field attribute
- 5ac462e2b7ac 18.0 landed