Re: Clean up NamedLWLockTranche stuff

Sami Imseih <samimseih@gmail.com>

From: Sami Imseih <samimseih@gmail.com>

To: Heikki Linnakangas <hlinnaka@iki.fi>

Cc: Nathan Bossart <nathandbossart@gmail.com>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2026-03-27T04:49:11Z

Lists: pgsql-hackers

Attachments

v1-0001-fix-some-comments-for-lwlock-tranches.patch (application/octet-stream) patch v1-0001

> +/* backend-local copy of NamedLWLockTranches->num_user_defined */
> +static int  LocalNumUserDefinedTranches;

> The comment here should reference "LWLockTranches->num_user_defined "
> instead.

> Also, there are a few places in lwlock.c where "named tranches" is mentioned.
> Maybe we should just say "user-defined tranches" instead?

Like the attached.

--
Sami

Commits

Fix outdated comment on MainLWLockArray
- bd365b1ae510 19 (unreleased) landed
Fix RequestNamedLWLockTranche in single-user mode
- 2407c8db159d 19 (unreleased) landed
Minor comment fixes to yesterday's LWLock tranche refactoring
- 98993150c0a4 19 (unreleased) landed
Move ShmemIndexLock into ShmemAllocator
- 06d859aaf4e9 19 (unreleased) landed
Use ShmemInitStruct to allocate lwlock.c's shared memory
- 30d432502bf4 19 (unreleased) landed
Use a separate spinlock to protect LWLockTranches
- 12e3e0f2c8f7 19 (unreleased) landed
Refactor how user-defined LWLock tranches are stored in shmem
- d6eba30a245c 19 (unreleased) landed
Rename MAX_NAMED_TRANCHES to MAX_USER_DEFINED_TRANCHES
- cc88481aeb98 19 (unreleased) landed
Fix re-initialization of LWLock-related shared memory.
- c3cc2ab87d72 19 (unreleased) cited