Horton

Re: [PATCH] Add loongarch native checksum implementation.

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: YANG Xudong <yangxudong@ymatrix.cn>, pgsql-hackers@lists.postgresql.org, wengyanqing@ymatrix.cn, wanghao@ymatrix.cn
Date: 2023-08-10T10:26:37Z
Lists: pgsql-hackers 
On Thu, Aug 10, 2023 at 10:35 AM John Naylor
<john.naylor@enterprisedb.com> wrote:
>
> On Tue, Aug 8, 2023 at 2:22 PM YANG Xudong <yangxudong@ymatrix.cn> wrote:
> >
> > On 2023/8/8 14:38, John Naylor wrote:
> >
> > > v4 0001 is the same as v3, but with a draft commit message. I will
> > > squash and commit this week, unless there is additional feedback.
> >
> > Looks good to me. Thanks for the additional patch.
>
> I pushed this with another small comment change. Unfortunately, I didn't glance at the buildfarm beforehand -- it seems many members are failing an isolation check added by commit fa2e87494, including both loongarch64 members. I'll check back periodically.
>
> https://buildfarm.postgresql.org/cgi-bin/show_status.pl
>

In MSVC build, on doing: perl mkvcbuild.pl after this commit, I am
facing the below error:
Generating configuration headers...
undefined symbol: USE_LOONGARCH_CRC32C at src/include/pg_config.h line
718 at ../postgresql/src/tools/msvc/Mkvcbuild.pm line 872.

Am I missing something or did the commit miss something?

--
With Regards,
Amit Kapila.

Commits

  1. Update Solution.pm for new LoongArch CRC symbol

  2. Use native CRC instructions on 64-bit LoongArch

  3. Recalculate search_path after ALTER ROLE.