Horton

Re: How can end users know the cause of LR slot sync delays?

Amit Kapila <amit.kapila16@gmail.com>

View thread
From: Amit Kapila <amit.kapila16@gmail.com>
To: Michael Banck <mbanck@gmx.net>
Cc: shveta malik <shveta.malik@gmail.com>, Shlok Kyal <shlok.kyal.oss@gmail.com>, "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Ashutosh Sharma <ashu.coek88@gmail.com>
Date: 2025-12-03T05:28:41Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Rename column slotsync_skip_at to slotsync_last_skip.

  2. Add slotsync_skip_reason column to pg_replication_slots view.

  3. Fix test failure caused by commit 76b78721ca.

  4. Fix a BF failure caused by commit 76b78721ca.

  5. Add slotsync skip statistics.

On Fri, Nov 28, 2025 at 3:37 PM Michael Banck <mbanck@gmx.net> wrote:
>
> Hi,
>
> On Fri, Nov 28, 2025 at 03:30:48PM +0530, Amit Kapila wrote:
> > I suggested the current one because having the last was making the
> > column name bit longer, and anyway the description clarifies it, but I
> > see your point. So, the other options could be
> > slotsync_last_skip_time, sync_last_skip_time, last_slotsync_skip_time,
> > last_sync_skip_time .
>
> I also noticed while going through src/backend/catalog/system_views.sql
> that *_last_*_time is rare, so in terms of brevity, removing the _time
> at the end would be ok. "last_" already conveys time/a timestamp.
>

I think it depends on case to case but having last in the similar
cases seems to be a common practice. So, again thinking about it based
on your suggestion and looking at existing fields, I suggest we should
rename slotsync_skip_at to slotsync_last_skip. This is similar to
checksum_last_failure. I think there is a value in keeping initials
the same for similar fields in the view as users could easily identify
the related columns while querying the view. For example,
checksum_failures and checksum_last_failure in pg_stat_database.

Anyone else have any opinion on the names proposed here?

-- 
With Regards,
Amit Kapila.