Horton

Re: pgsql: Avoid creation of the free space map for small heap relations, t

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: John Naylor <john.naylor@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Amit Kapila <akapila@postgresql.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-01T02:19:46Z
Lists: pgsql-hackers 
On Thu, Feb 28, 2019 at 9:59 AM John Naylor <john.naylor@2ndquadrant.com> wrote:
>
> On Thu, Feb 28, 2019 at 10:25 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > Here's an updated patch based on comments by you.  I will proceed with
> > this unless you have any more comments.
>
> Looks good to me. I would just adjust the grammar in the comment, from
> "This prevents us to use the map", to "This prevents us from using the
> map". Perhaps also a comma after "first".
>

Okay, pushed after making changes suggested by you.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Clear the local map when not used.

  2. Remove unneeded argument from _bt_getstackbuf().

  3. Avoid creation of the free space map for small heap relations, take 2.