Re: Write Ahead Logging for Hash Indexes

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Jeff Janes <jeff.janes@gmail.com>, Jesper Pedersen <jesper.pedersen@redhat.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2016-12-05T07:46:38Z
Lists: pgsql-hackers

Attachments

On Fri, Dec 2, 2016 at 7:07 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Thu, Dec 1, 2016 at 6:51 PM, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>>  Of course, ideally I can
>>> also start reviewing this one in the meantime.  Does that make sense
>>> to you?
>>>
>>
>> You can start reviewing some of the operations like "Create Index",
>> "Insert".  However, some changes are required because of change in
>> locking strategy for Vacuum.  I am planning to work on rebasing it and
>> making required changes in next week.
>
> I'll review after that, since I have other things to review meanwhile.
>

Attached, please find the rebased patch attached with this e-mail.
There is no fundamental change in patch except for adapting the new
locking strategy in squeeze operation.  I have done the sanity testing
of the patch with master-standby setup and Kuntal has helped me to
verify it with his wal-consistency checker patch.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Add a regression test for snapshot too old with hash indexes.

  2. hash: Add write-ahead logging support.

  3. Improve coding in _hash_addovflpage.

  4. Remove _hash_wrtbuf() in favor of calling MarkBufferDirty().

  5. Improve hash index bucket split behavior.