Re: SerializeParamList vs machines with strict alignment

Amit Kapila <amit.kapila16@gmail.com>

From: Amit Kapila <amit.kapila16@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, hlinnaka <hlinnaka@iki.fi>
Date: 2018-10-03T04:32:09Z
Lists: pgsql-hackers
On Wed, Oct 3, 2018 at 8:29 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Oct 3, 2018 at 12:25 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >
> > Amit Kapila <amit.kapila16@gmail.com> writes:
> > >> Okay, I have pushed the test case patch on HEAD.  Attached is the
> > >> code-fix patch, let's wait for a day so that we have all the results
> > >> which can help us to discuss the merits of this patch.
> >
> > > By now, the added test has failed on gharial [1] with below log on the server:
> >
> > Yeah, gharial and anole both don't like this, which is interesting
> > but not really surprising, considering that IA64 is in some part
> > an HPPA follow-on architecture.
> >
>
> Now chipmunk also failed for the same test.
>
> >  What I find more interesting is
> > that both of the live Sparc critters are happy --- so despite
> > Thomas' statements upthread, they're coping with unaligned accesses.
> > Maybe you should have back-patched the test to older branches so
> > we could see what castoroides and protosciurus would do.  But it's
> > probably not worth additional delay.
> >
>
> Agreed, I will push the code-fix on HEAD and code+test in back-branches.
>

Pushed, let's wait and see if this can make all the failing buidfarm
members (due to this issue) happy.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com


Commits

  1. MAXALIGN the target address where we store flattened value.

  2. Test passing expanded-value representations to workers.