Horton

Re: [PATCH] Use indexes on the subscriber when REPLICA IDENTITY is full on the publisher

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: Önder Kalacı <onderkalaci@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, "shiy.fnst@fujitsu.com" <shiy.fnst@fujitsu.com>, Peter Smith <smithpb2250@gmail.com>, "wangw.fnst@fujitsu.com" <wangw.fnst@fujitsu.com>, Marco Slot <marco.slot@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-03-18T09:49:43Z
Lists: pgsql-hackers 
On Thu, Mar 16, 2023 at 2:15 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Wed, Mar 15, 2023 at 9:12 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Tue, Mar 14, 2023 at 3:18 PM Önder Kalacı <onderkalaci@gmail.com> wrote:
> > >>
> >
> > Pushed this patch but forgot to add a new testfile. Will do that soon.
> >
>
> The main patch is committed now. I think the pending item in this
> thread is to conclude whether we need a storage or subscription to
> disable/enable this feature. Both Andres and Onder don't seem to be in
> favor but I am of opinion that it could be helpful in scenarios where
> the index scan (due to duplicates or dead tuples) is slower. However,
> if we don't have a consensus on the same, we can anyway add it later.
> If there are no more votes in favor of adding such an option, we can
> probably close the CF entry.
>

I have closed this CF entry for now. However, if there is any interest
in pursuing the storage or subscription option for this feature, we
can still discuss it.

-- 
With Regards,
Amit Kapila.

Commits

  1. Add the testcases for 89e46da5e5.

  2. Allow the use of indexes other than PK and REPLICA IDENTITY on the subscriber.

  3. Rework query relation permission checking

  4. Generalize ri_RootToPartitionMap to use for non-partition children

  5. Add wait_for_subscription_sync for TAP tests.

  6. Logical replication