Horton
Menu

Re: Column Filtering in Logical Replication

Amit Kapila <amit.kapila16@gmail.com>

View thread
From: Amit Kapila <amit.kapila16@gmail.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Justin Pryzby <pryzby@telsasoft.com>, "houzj.fnst@fujitsu.com" <houzj.fnst@fujitsu.com>, Rahila Syed <rahilasyed90@gmail.com>, Peter Smith <smithpb2250@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2022-02-16T09:30:29Z
Lists: pgsql-hackers 
On Wed, Feb 16, 2022 at 6:09 AM Tomas Vondra
<tomas.vondra@enterprisedb.com> wrote:
>
> On 2/16/22 01:33, Alvaro Herrera wrote:
> >
> >> 3) partitioning with pubivaroot=false
> >>
> >> When a partitioned table is added with (pubviaroot=false), it should not be
> >> subject to column filter on the parent relation, which is the same behavior
> >> used by the row filtering patch.
> >
> > You mean each partition should define its own filter, or lack of filter?
> > That sounds reasonable.
> >
>
> If the partition is not published by the root, it shouldn't use the
> filter defined on the root. I wonder what should happen to the filter
> defined on the partition itself. I'd say
>
> pubviaroot=false -> use filter defined on partition (if any)
>
> pubviaroot=true -> use filter defined on root (if any)
>
>
> I wonder what the row filter patch is doing - we should probably follow
> the same logic, if only to keep the filtering stuff consistent.
>

The row filter patch is doing the same and additionally, it gives an
error if the user provides a filter for a partitioned table with
pubviaroot as false.

-- 
With Regards,
Amit Kapila.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Explain about Column List feature.

  2. Doc: fix column list vs. replica identity rules.

  3. Prohibit combining publications with different column lists.

  4. Fix the check to limit sync workers.

  5. Wait for subscription to sync in t/031_column_list.sql

  6. Move prattrs to the pg_publication_rel section in docs

  7. Allow specifying column lists for logical replication

  8. Fix row filters with multiple publications

  9. Fix publish_as_relid with multiple publications

  10. Add some additional tests for row filters in logical replication.

  11. Add index on pg_publication_rel.prpubid

  12. Avoid using DefElemAction in AlterPublicationStmt

  13. Small cleanups related to PUBLICATION framework code

  14. Add PublicationTable and PublicationRelInfo structs

  15. Fix various concurrency issues in logical replication worker launching