Horton

Re: Rename sync_error_count to tbl_sync_error_count in subscription statistics

Amit Kapila <amit.kapila16@gmail.com>

View thread View on postgr.es
From: Amit Kapila <amit.kapila16@gmail.com>
To: vignesh C <vignesh21@gmail.com>
Cc: Peter Smith <smithpb2250@gmail.com>, shveta malik <shveta.malik@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Masahiko Sawada <sawada.mshk@gmail.com>, Dilip Kumar <dilipbalaut@gmail.com>
Date: 2025-11-18T06:01:46Z
Lists: pgsql-hackers 
On Mon, Nov 17, 2025 at 4:35 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, Nov 13, 2025 at 3:22 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > On Thu, 13 Nov 2025 at 09:12, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > > On Thu, Nov 13, 2025 at 4:31 AM Peter Smith <smithpb2250@gmail.com> wrote:
> > > >
> > > > CURRENT
> > > > seq_sync_error_count
> > > > sync_error_count
> > > >
> > > > MY SUGGESTION
> > > > sync_seq_error_count
> > > > sync_table_error_count
> > > >
> > >
> > > +1. Along with consistency with other column names, it will also make
> > > it easier for users to group and query all 'sync' related counts
> > > together.
> >
> > This seems better, the attached v2 version patch has the changes for the same.
> >
>
> The patch looks good to me. I'll push this tomorrow unless there are
> any new reviews or suggestions.
>

Pushed.

-- 
With Regards,
Amit Kapila.

Commits

  1. Rename two columns in pg_stat_subscription_stats.